[gstreamer-bugs] [Bug 584269] New: Enhance decodebin bindings

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=584269

  GStreamer | gst-sharp | Ver: git
           Summary: Enhance decodebin bindings
           Product: GStreamer
           Version: git
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-sharp
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: mkbosmans at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
     GNOME version: Unspecified
   GNOME milestone: Unspecified


The second argument of the new-decoded-pad signal, islast, is deprecated [1]
and probably not of much use for the managed world anyway.

--- a/gstreamer-sharp/baseplugins/decodebin.metadata
+++ b/gstreamer-sharp/baseplugins/decodebin.metadata
@@ -2,4 +2,4 @@
 <metadata>
   <attr
path="/element/element-signals/signal/name[child::text()='new-decoded-pad']/../params/type[1]"
name="name">Pad</attr>
-  <attr
path="/element/element-signals/signal/name[child::text()='new-decoded-pad']/../params/type[2]"
name="name">Last</attr>
+  <remove-node
path="/element/element-signals/signal/name[child::text()='new-decoded-pad']/../params/type[2]"
/>
   <attr
path="/element/element-signals/signal/name[child::text()='removed-decoded-pad']/../params/type[1]"
name="name">Pad</attr>


With the seconds argument removed, NewDecodedPadArgs and RemovedDecodedPadArgs
now have the same signature. Wouldn't it make more sense to simply have a
DecodedPadArgs and DecodedPadHandler shared for both signals?

The same would go for FakeSink.Handoff, FakeSink.PrerollHandof, FakeSrc.Handoff
and Identity.Handoff. They all share the same signature and semantics, so the
cleanest api would be for those shared Args/Handlers to live in the
Gst.CorePlugins or Gst.BasePlugins namespace as normal classes.


[1]
http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-plugins/html/gst-plugins-base-plugins-decodebin.html#GstDecodeBin-new-decoded-pad


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=584269.