[gstreamer-bugs] [Bug 554460] thumbnailer crash in gst_fake_sink_event() on FLUSH_START event

[GStreamer (bugzilla.gnome.org)]

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=554460

  GStreamer | gstreamer (core) | Ver: 0.10.x

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135656|none                        |rejected
               Flag|                            |
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.24




------- Comment #5 from Tim-Philipp Müller  2009-05-31 19:11 UTC -------
Solved this slightly differently without touching basesink: instead of the
stream lock, just have a common lock for all g_object_notify() per instance
(let's hope the bug is not per class - if it is, then it's much harder to run
into that at least).

 commit 7e4b164c125926784805446482151e4e7bfffe96
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Sat May 30 20:36:25 2009 +0100

    fakesink: hack around crasher bug in g_object_notify() for out-of-band
events

    GObject may crash if two threads do concurrent g_object_notify() on the
same
    object. This may happen if fakesink receives an out-of-band event such as
    FLUSH_START while processing a buffer or serialised event in the streaming
    thread. Since this may happen with the default settings during a common
    operation like a seek, and there seems to be little chance of a timely fix
    in GObject (see #166020), we should hack around this issue by protecting
all
    of fakesink's direct g_object_notify() calls with a lock.

    Also add unit test for the above.

    Fixes #554460.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=554460.