[gstreamer-bugs] [Bug 599649] Support for frame-based subtitles using playbin2 and subparse

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Nov 6 06:55:59 PST 2009


https://bugzilla.gnome.org/show_bug.cgi?id=599649
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #146258|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2009-11-06 14:55:57 UTC ---
Review of attachment 146258:
 --> (https://bugzilla.gnome.org/review?bug=599649&attachment=146258)

For the property, better use a property of type GstFraction. It can still be
converted to a double if any format requires it but the conversion to double
looses precision.
Then you don't use that property anywhere in subparse, would be nice to see how
exactly this is used in the MicroDVD parser for example :)

Then for the playbin2 part. In playbin2 you can have multiple video streams, I
guess you should always use the framerate of the currently selected video
stream and update it when the video stream changes, etc.
And then about setting the video framerate on subparse, subtitles can also be
in uridecodebin, not only in suburidecodebin.

But all that becomes much easier once the patches in bug #595123 have landed.
Then the video-fps handling can all be done inside subtitleoverlay without the
need of touching playbin2... we already have the current video and subtitle
stream there, could get the framerate and set it on the parser if it has a
video-fps property.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list