[gstreamer-bugs] [Bug 599649] Support for frame-based subtitles using playbin2 and subparse

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Nov 7 00:28:35 PST 2009


https://bugzilla.gnome.org/show_bug.cgi?id=599649
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at circular-chaos.org

--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2009-11-07 08:28:30 UTC ---
(In reply to comment #4)
> > But all that becomes much easier once the patches in bug #595123 have landed.
> > Then the video-fps handling can all be done inside subtitleoverlay without the
> > need of touching playbin2... we already have the current video and subtitle
> > stream there, could get the framerate and set it on the parser if it has a
> > video-fps property.
> 
> That sounds like a better idea (at least until people demand that they should
> be able to set the assumed framerate for the subtitle stream manually for some
> reason).

Well, then they could still set it on subparse manually :) Or what do you mean?

> I was also toying with the idea of sending a custom event of some sort
> (from the overlay element onto the text/sub pad) to inform the subtitle parser
> if the currently configured framerate.

Do you think that should still be added? IMHO it's cleaner to have it all
inside subtitleoverlay, where the current video caps and subtitle elements are
all bundled into a single bin. But such event might be useful in other
circumstances maybe, I don't know

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list