[gstreamer-bugs] [Bug 600922] gst-launch: wake up less often to check for Ctrl-C

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=600922
  GStreamer | gstreamer (core) | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.26
            Summary|[Power enhancement]:        |gst-launch: wake up less
                   |Replace g_timeout_add (50,  |often to check for Ctrl-C
                   |...) with                   |
                   |g_timeout_add_seconds (1,   |
                   |...) for gst-launch         |

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2009-11-07 20:37:38 UTC ---
gst-launch is primarily a debugging and testing tool and as such it is not
supposed to be memory or cpu efficient or even provide exemplary code.

I don't quite share your assertion that a one-second interval is enough to
capture Ctrl-C "without perceivable lag". 250ms, however, seemed quite
acceptable and should reduce wakeups a lot.

g_timeout_add_seconds() makes sense in a more complex scenario where multiple
timeouts that are multiples of 1s are in use, but this is not the case in
gst-launch, so I don't see a strong case for using it here.

I hope reducing the wakeups to 4 times per second is acceptable to you.

 commit ed86995cd80e390e6e4e0f78350b386b1d7797d5
 Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
 Date:   Sat Nov 7 20:22:49 2009 +0000

    gst-launch: wake up less often to check if we've been interrupted

    Check if we've been interrupted only four times per second instead
    of twenty times per second, to wake up the cpu less often and
    save power (see bug #600922).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.