[gstreamer-bugs] [Bug 599649] Support for frame-based subtitles using playbin2 and subparse

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Nov 8 22:59:12 PST 2009


https://bugzilla.gnome.org/show_bug.cgi?id=599649
  GStreamer | gst-plugins-base | git

--- Comment #9 from Iago Toral <itoral at igalia.com> 2009-11-09 06:59:08 UTC ---
(In reply to comment #3)
> Review of attachment 146258 [details]:
> 
> For the property, better use a property of type GstFraction. It can still be
> converted to a double if any format requires it but the conversion to double
> looses precision.

Yeah, makes sense.

> Then you don't use that property anywhere in subparse, would be nice to see how
> exactly this is used in the MicroDVD parser for example :)

I do :). I set parser->state.fps in handle_buffer to the value set in the
property (only when self->first_buffer is TRUE), which is then used in
MicroDVD's parse line function. Since MicroDVD's parse line only uses the fps
from the file (or the hardcoded 24.00) if self->state.fps == 0, it will end up
using the one established by playbin2, so I did not need to change any in
MicroDVD's parser.

> Then for the playbin2 part. In playbin2 you can have multiple video streams, I
> guess you should always use the framerate of the currently selected video
> stream and update it when the video stream changes, etc.

Yes, I noticed that but I thought I would first submit a patch with this proof
of concept and see what you guys think, since I was not very convinced about
this being the best way to go for the fix.

> And then about setting the video framerate on subparse, subtitles can also be
> in uridecodebin, not only in suburidecodebin.

Ah, this was something I did not had in mind.

> But all that becomes much easier once the patches in bug #595123 have landed.
> Then the video-fps handling can all be done inside subtitleoverlay without the
> need of touching playbin2... we already have the current video and subtitle
> stream there, could get the framerate and set it on the parser if it has a
> video-fps property.

Aha, that's sounds like a much better approach indeed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list