[gstreamer-bugs] [Bug 600787] playbin2 has a problem with Ogg stream with "info"
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Nov 14 01:22:35 PST 2009
https://bugzilla.gnome.org/show_bug.cgi?id=600787
GStreamer | gst-plugins-base | 0.10.25
--- Comment #7 from Sebastian Dröge <slomo at circular-chaos.org> 2009-11-14 09:22:30 UTC ---
Review of attachment 147715:
--> (https://bugzilla.gnome.org/review?bug=600787&attachment=147715)
Good work :) Some comments below
::: gst/playback/gstdecodebin2.c
@@ +2265,3 @@
+ gst_element_release_request_pad (group->multiqueue, rpad->pad);
+ gst_object_unref (rpad->pad);
+ g_free (rpad);
Please use GSlice for allocating these structs
@@ +2440,3 @@
+ GstRequestPadInfo *rpad_iter = (GstRequestPadInfo *) iter->data;
+ if (!rpad_iter->has_eos)
+ break;
That break will only exit the loop but you probably wanted to exit the switch
statement, right?
@@ +2454,3 @@
+ case GST_EVENT_FLUSH_STOP:
+ rpad->has_eos = FALSE;
+ /* TODO maybe we should set the next group back to preroll buffering */
No idea either but NEWSEGMENT events could also be filler segments for sparse
streams, in that case resetting to preroll-buffering is not a good idea I guess
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs
mailing list