[gstreamer-bugs] [Bug 603376] New: rtpsession : g_type_create_instance performance issue : avoid buffer ref

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Nov 30 06:21:53 PST 2009


https://bugzilla.gnome.org/show_bug.cgi?id=603376
  GStreamer | gst-plugins-good | git

           Summary: rtpsession : g_type_create_instance performance issue
                    : avoid buffer ref
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: gstelzz at yahoo.fr
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=148743)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=148743)
copy csrc in glist. Do not ref buffer

rtpsession always ref the incoming buffer to process csrc after buffer has been
pushed (rtp_session_process_rtp).
Problem is that with gstrtpbin, downstream elements include a jitterbuffer
which issues a gst_buffer_make_metadata_writable (gst_rtp_jitter_buffer_chain).
This gst_buffer_make_metadata_writable always does a metadata copy, because
buffer has been reffed peviously.
This leads to the known performance issue in g_type_create_instance
(gst_buffer_create_sub / gst_mini_object_new).

Here is a patch which copies csrc into a glist for further processing, avoiding
buffer ref.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list