[gstreamer-bugs] [Bug 603376] rtpsession : g_type_create_instance performance issue : avoid buffer ref

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Nov 30 07:05:50 PST 2009


https://bugzilla.gnome.org/show_bug.cgi?id=603376
  GStreamer | gst-plugins-good | git

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.18

--- Comment #1 from Wim Taymans <wim.taymans at gmail.com> 2009-11-30 15:05:46 UTC ---
Good idea! I changed it a bit to use an array instead of a GList to avoid some
allocations (not that CSRCs are very common).

commit 07f27f0efd5a866721fd83c6873e7eacc989c0fe
Author: Aurelien Grimaud <gstelzz at yahoo dot fr>
Date:   Mon Nov 30 15:59:50 2009 +0100

    rtpsession: avoid buffer ref/unref pairs for CSRCs

    We ref the buffer before pushing it downstream in order to get the CSRCs of
it
    after pushing. This causes performance problems when downstream elements
want to
    change the metadata because the buffer needs to be subbuffered.

    Instead, read and store the CSRCs of the buffer in an array before pushing
it
    and process the array after pushing the buffer. This allows us to remove
the
    ref/unref pair.

    Fixes #603376

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list