[gstreamer-bugs] [Bug 598763] New plugin: aiffmux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=598763
  GStreamer | gst-plugins-bad | git

--- Comment #1 from Edward Hervey <bilboed at gmail.com> 2009-10-17 13:20:09 UTC ---
Review of attachment 145658:

::: gst/aiffmux/aiffmux.c
@@ +97,3 @@
+    GST_PAD_SRC,
+    GST_PAD_ALWAYS,
+    GST_STATIC_CAPS ("audio/x-raw-aiff")

You should use the same caps as existing plugins. aiffparse, ffdemux_aiff and
ffmux_aiff all use "audio/x-aiff"

@@ +176,3 @@
+ * Copyright (c) 2005 Michael Niedermayer <michaelni at gmx.at>
+ */
+

while it makes sense to re-use existing code... you could maybe try to make a
GST_{READ|WRITE}_IEEE80FLOAT_* or extend GstByteReader/Writer to support that,
like that other plugins can benefit from it too.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.