[gstreamer-bugs] [Bug 599870] [API] micro-optimisation: add GST_DEBUG_FUNCPTR_FULL

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=599870
  GStreamer | gstreamer (core) | git

--- Comment #8 from Edward Hervey <bilboed at gmail.com> 2009-10-28 10:24:33 UTC ---
(In reply to comment #6)
> > Changing that mutex to a RW lock and letting _gst_debug_register_funcptr()
> > first take a R lock to check if it already is inserted and only take a W lock
> > if it isn't might be a cleaner fix though.
> 
> Depends on whether the issue was primarily contention (doubtful?) or the hash
> table lookups I guess.

both actually.

For every single element/pad/object that you create that uses those
decorators... you'll be:
(1) introducing extra contention, what's worse not once but many times (for
every GST_DEBUG_FUNCPTR call)
(2) using g_hash_table ... when you shouldn't need to

Maybe we could adjust the macro to be a G_STMT with the volatile inside.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.