[gstreamer-bugs] [Bug 582569] GstBaseDecode class

[GStreamer (bugzilla.gnome.org)]

http://bugzilla.gnome.org/show_bug.cgi?id=582569



--- Comment #9 from Iago Toral <itoral at igalia.com> 2009-09-01 12:38:04 UTC ---
Ok, so I created this:

http://gitorious.org/gst-plugins-bad-audio-codec-base-classes/gst-plugins-bad-audio-codec-base-classes/trees/master/gst-libs/gst/audio

which contains two classes: GstBaseAudioCodec and GstBaseAudioDecoder, being
the latter a subclass of the former.

The original idea was to mimic what we have for video, but now I am not sure if
this makes sense, as I feel like GstBaseAudioCodec could be enough. Right now,
all the important behavior is in GstBaseAudioCodec. Probably it is just my lack
of experience, I guess more experienced codec developers can point out
differences in the behavior of encoders and decoders that justify having such
subclasses of GstBaseAudioCodec, just tell me about them and I'll implement it.

I added gtk-doc documentation so reviewers should have an easier time
understanding the decisions I made when implementing this.

I tested this implementation with the AMR-NB decoder and it worked well for me.
I guess I should give it a try with more complex decoders. Also, I should
probably try an encoder and see if GstBaseAudioCodec alone works well for that
case too.

As a side note, if you look at GstBaseAudioDecoder you'll see that it does not
implement any decoder specific stuff (this is handled all at GstBaseAudioCodec,
and hence the reason I doubt that subclasses of this are needed). Currently
GstBaseAudioDecoder just implements a few source events and query functions,
but I am not even sure if that's actually necessary/useful. Actually, I think
most of these are handled by other elements in the pipeline (demuxers I guess),
so maybe it is not worth the effort.

So now I would like to have someone reviewing this and giving some feedback so
I can add/fix whatever needs to be added or fixed :)

-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.