[gstreamer-bugs] [Bug 593955] New: rtpjitterbuffer: clock_rate can change between its check and its use

[GStreamer (bugzilla.gnome.org)]

http://bugzilla.gnome.org/show_bug.cgi?id=593955

           Summary: rtpjitterbuffer: clock_rate can change between its
                    check and its use
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: tester at tester.ca
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


--- Comment #0 from Olivier Crete (Tester) <tester at tester.ca> 2009-09-02 19:23:31 UTC ---
Created an attachment (id=142347)
Lock the clock rate variable

The priv->clock_rate variable could become -1 between when its checked to not
be -1 and when its used, causing an assertion. Attached patch fixes that by
taking the mutex earlier in the chain() function and locking other changes to
the clock_rate variable.

Also in _loop(), it uses the clock_rate() without checking if its not -1, but I
guess thats for rtsp, so it doesn't matter.

-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.