[gstreamer-bugs] [Bug 594279] dshowsrcwrapper: use tchar macro for string literals

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Sep 7 07:49:16 PDT 2009


http://bugzilla.gnome.org/show_bug.cgi?id=594279



--- Comment #3 from Julien Isorce <julien.isorce at gmail.com> 2009-09-07 14:49:11 UTC ---
I did a fresh frozen build then I only did:

--- a/sys/dshowsrcwrapper/gstdshowfakesink.cpp
+++ b/sys/dshowsrcwrapper/gstdshowfakesink.cpp
@@ -25,7 +25,7 @@ CDshowFakeSink::CDshowFakeSink ():
m_hres (S_OK),
m_callback (NULL),
m_data (NULL),
-CBaseRenderer (CLSID_DshowFakeSink, "DshowFakeSink", NULL, &m_hres)
+CBaseRenderer (CLSID_DshowFakeSink, _T("DshowFakeSink"), NULL, &m_hres)

And then I's ok for both unicode and MBCS.

See commit:

--- a/sys/dshowsrcwrapper/gstdshowfakesink.cpp
+++ b/sys/dshowsrcwrapper/gstdshowfakesink.cpp
@@ -25,7 +25,7 @@ CDshowFakeSink::CDshowFakeSink ():
m_hres (S_OK),
m_callback (NULL),
m_data (NULL),
-CBaseRenderer (CLSID_DshowFakeSink, "DshowFakeSink", NULL, &m_hres)
+CBaseRenderer (CLSID_DshowFakeSink, _T("DshowFakeSink"), NULL, &m_hres)

So if you still think other L".." must be replaced by _T then please make a new
patch. Thx

-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list