[gstreamer-bugs] [Bug 164870] PNM [en,de]coder

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=164870


Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW


--- Comment #20 from Sebastian Dröge <slomo at circular-chaos.org> 2009-09-09 14:21:46 UTC ---
General:
- Add your copyright to the header of all files

gstpnm.c:
- shared-mime-info uses image/x-portable-anymap as mimetype for PNM images,
maybe use that in your plugin too and differentiate between grayscale, etc by
cap fields
- The extension of PNM files seems to be pnm, not ps
- You could as well make a patch against gst-plugins-base/gst/typefindfunctions
for the PNM typefinder :)


gstpnmdec.c:
- Use GST_BOILERPLATE
- Why don't you just store pointers to the src/sinkpads in the instance struct?
- Move the instance/class struct and all the GST_FOO_BAR_GET_STUFF() macros to
the header. Otherwise gtk-doc is unhappy :)
- You might want to use a GstAdapter instead of the buffer-copy-merging stuff


gstpnmenc.c:
- Why do you only write the header if the buffer has no offset?
- BOILERPLATE, src/sinkpads pointers, instance/class structs stuff from
gstpnmdec.c applies here too
- You could as well use gst_structure_get_int() instead of getting the value
and then the int from the value

gstpnmutils.[ch]:
- Add license/copyright

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.