[gstreamer-bugs] [Bug 594663] Patch for multifilesink

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Sep 9 09:50:22 PDT 2009


https://bugzilla.gnome.org/show_bug.cgi?id=594663


Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wim.taymans at gmail.com


--- Comment #2 from Wim Taymans <wim.taymans at gmail.com> 2009-09-09 16:50:14 UTC ---
Some comments:

 - Make the message name something more unique like "GstMultiFilesink" instead
   of "Info".
 - The message fields should be lowercase.
 - The timestamp of the buffer does not mean much without the preceeding
   newsegment. Better add  stream-time, running-time, duration (see also
   -good/gst/spectrum/gstspectrum.c)
 - use GST_TYPE_CLOCK_TIME for the timestamp values (not string)
 - You probably also want the buffer offsets because most file data is byte
   based.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list