[gstreamer-bugs] [Bug 353970] [capsfilter] doesn't filter caps correctly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=353970



--- Comment #5 from Sebastian Dröge <slomo at circular-chaos.org> 2009-09-10 07:45:50 UTC ---
(In reply to comment #3)
> The patch is problematic in setups like totem-video-thumbnailer (e.g. as in bug
> #369502), where conversion will fail in a setup like:
> 
>   ... ! videoscale ! filtercaps ! sink
> 
> where the filtercaps set are fixed and very specific, including a
> pixel-aspect-ratio=1/1 field. In the process of negotiation, capsfilter will
> get the template caps from videoscale's source pad and those don't have a
> pixel-aspect-ratio field, so things will error out here because caps are
> allegedly incompatible. Arguably this needs to be added to videoscale's
> template caps then, but in any case it seems this isn't really a feasable way
> to go, so I guess it comes down to upstream doing better caps nego.

Adding it to videoscales template caps means, that videoscale only accepts caps
with p-a-r fields. Which then means, that we need to include p-a-r in every
video caps and the current no-par-is-1:1 convention wouldn't work anymore.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.