[gstreamer-bugs] [Bug 595029] pulse elements fail to connect to pulse 0.9.9

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=595029
  GStreamer | gst-plugins-good | 0.10.16

Stefan Kost (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ensonic at sonicpulse.de

--- Comment #3 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2009-09-13 19:40:17 UTC ---
If we are talking about that:

  memset (&buf_attr, 0, sizeof (buf_attr));
  buf_attr.tlength = spec->segtotal * spec->segsize;
  buf_attr.maxlength = -1;
  buf_attr.prebuf = 0;
  buf_attr.minreq = -1;

we were using values from the GstRingbuffer before and we could easily add an
ifdef to do that again for older versions. If we certainly know that 0.9.9 is
affected I would suggest to do

  memset (&buf_attr, 0, sizeof (buf_attr));
  buf_attr.tlength = spec->segtotal * spec->segsize;
  buf_attr.prebuf = 0;
#if HAVE_PULSE_0_9_10
  buf_attr.maxlength = -1;
  buf_attr.minreq = -1;
#else
  buf_attr.maxlength = buf_attr.tlength * 2;
  buf_attr.minreq = spec->segsize;
#endif

See commit b3c55f5ce5301d218596b199c893232802948a42

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.