[gstreamer-bugs] [Bug 595256] New: theoraenc: Buffer not time-contiguous with previous one

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=595256
  GStreamer | gst-plugins-base | git

           Summary: theoraenc: Buffer not time-contiguous with previous
                    one
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: marcandre.lureau at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


The following produces warnings.

GST_DEBUG=*theora*:4,identity:4 gst-launch videotestsrc ! theoraenc ! identity
check-perfect=1 ! fakesink -v 2>&1 | grep -v data-cont | grep -v FakeSink |
grep WARN

It seems that in function theora_enc_get_ogg_packet_end_time()

theora_granule_time (&enc->state, end_granule) * GST_SECOND

has rounding issues. (for ex. the double 7.4000000 becomes 0.7399999 in
clocktime)

One way to hack the issue is to replace:


 GST_BUFFER_TIMESTAMP (buf) = timestamp;
by
 GST_BUFFER_TIMESTAMP (buf) = running_time;

Would that be acceptable??

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.