[gstreamer-bugs] [Bug 595215] PNM encoder doesn't support ASCII encoding

Tue Sep 15 23:23:27 PDT 2009

https://bugzilla.gnome.org/show_bug.cgi?id=595215
  GStreamer | gst-plugins-bad | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.15

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2009-09-16 06:23:23 UTC ---
Ok, I've committed this. One minor thing though: You should add the encoding to
the caps IMHO, this way the decoder can already declare from the caps that it
doesn't support ASCII. Also the ASCII property could go away then and it could
be selected depending on downstream caps.

The problem with the ASCII encoding that I meant is, that you add a newline
after the *first* byte (i == 0 && i % something == 0) and then after every 20
bytes (which is correct of course). That's not a real problem, it's just not
beautiful ;)

commit 93172c445311eadeef82107382bcfccdb47d33dc
Author: Lutz Mueller <lutz at topfrose.de>
Date:   Wed Sep 16 08:22:19 2009 +0200

    pnm: Support ASCII format for encoding and handle unsupported formats
better

    Fixes bug #595215.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.