[gstreamer-bugs] [Bug 596078] Playbin2 takes ref of audio-/video-sink parameter

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=596078
  GStreamer | gst-plugins-base | git

Jan Schmidt <thaytan> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thaytan at mad.scientist.com

--- Comment #7 from Jan Schmidt <thaytan at mad.scientist.com> 2009-09-28 19:28:58 UTC ---
Am I missing something? gst_play_sink_set_sink/gst_play_sink_set_vis_plugin
already add a ref, so gst_value_get_object is fine in the caller.

I think the problem is the one I started discussing with Wim some time ago,
that gstplaysink calls gst_object_sink to sink the floating reference on the
passed element. That seems to have been removed for the audio/video sinks when
gst_play_sink_set_video_sink and gst_play_sink_set_audio_sink were unified into
the gst_play_sink_set_sink() function, but it still seems to be true for the
gst_play_sink_set_vis_plugin() function - causing some inconsistency.

I think playbin2 should not sink the ref on the passed objects, and make it
uniformly the caller's responsibility.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.