[gstreamer-bugs] [Bug 615789] [ximagesink] warning / race

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=615789
  GStreamer | gst-plugins-base | git

--- Comment #2 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-04-15 08:36:20 UTC ---
A backtrace would be nice. gst_ximagesink_xwindow_update_geometry is called
from two places:

gst_ximagesink_expose()

gst_ximagesink_handle_xevents()
here it is called within
  while (XCheckWindowEvent (ximagesink->xcontext->disp,
          ximagesink->xwindow->win, ExposureMask | StructureNotifyMask, &e)) {

so the assert would trigger earlier. But then the check is a bit stupid
nowadays. From the two places where we call with we pass ximagesink->xwindow as
xwindow and inside gst_ximagesink_xwindow_update_geometry() deref
ximagesink->xwindow again.

So the assert should either just check ximagesink->xwindow and we remove the
extra parameter or we use the passed parameter.

The former change is already in xvimagesink. I attach a patch in a sec.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.