[gstreamer-bugs] [Bug 609658] [rtph264depay] doesn't mark output frames as keyframes correctly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=609658
  GStreamer | gst-plugins-good | 0.10.16

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-04-16 10:17:43 UTC ---
Review of attachment 158802:
 --> (https://bugzilla.gnome.org/review?bug=609658&attachment=158802)

Is this something we should get into the release as well?

::: gst/rtp/gstrtph264depay.c
@@ +418,3 @@
+    return FALSE;
+
+  nal_unit_type = (GST_BUFFER_DATA (nal))[4] & 0x1f;

Doesn't this mean we should check for GST_BUFFER_SIZE (nal) < 5 above?

@@ +422,3 @@
+  /* non-IDR VCL layer NAL considered DELTA */
+  if (nal_unit_type >= 1 && nal_unit_type <= 4) {
+    GST_BUFFER_FLAG_SET (nal, GST_BUFFER_FLAG_DELTA_UNIT);

Can we assume the buffer metadata is always writable? (Do we know the return
value of _take_buffer() is always metadata-writable?)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.