[gstreamer-bugs] [Bug 615783] reworked timestamping in adder

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=615783
  GStreamer | gst-plugins-base | git

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2010-04-16 17:56:39 UTC ---
Review of attachment 158756:
 --> (https://bugzilla.gnome.org/review?bug=615783&attachment=158756)

Looks good in general but

::: gst/adder/gstadder.c
@@ +728,2 @@
       else
+        adder->segment_start = 0;

You should probably either refuse seeks with a different type or correctly
handle them instead of just doing a [0,-1] seek :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.