[gstreamer-bugs] [Bug 615783] reworked timestamping in adder

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=615783
  GStreamer | gst-plugins-base | git

--- Comment #4 from Stefan Kost (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2010-04-17 18:37:19 UTC ---
(In reply to comment #3)
> Yes, either that or implement them.

Given that it was previously not handled for start anyway and the general state
of support for GST_SEEK_TYPE_CUR/GST_SEEK_TYPE_END I would prefer to keep the
patch as it is in this regard. If I would add support for it, it should be done
as a separate patch (and feature request). It would also require to first fix
sources to be able to test it even. I thing assuming an open end (which is the
default anyway) is sane thing to do.


> find . -name "*.c" -exec grep -Hn "GST_SEEK_TYPE_CUR" {} \; | egrep -v "(check|enum)"
./gst-plugins-bad/gst/tta/gstttaparse.c:190:          case GST_SEEK_TYPE_CUR:
./gst-plugins-bad/ext/metadata/gstbasemetadata.c:1475:      if (start_type ==
GST_SEEK_TYPE_CUR)
./gst-plugins-bad/ext/metadata/gstbasemetadata.c:1500:      if (stop_type ==
GST_SEEK_TYPE_CUR)
./gst-plugins-base/gst-libs/gst/tag/gsttagdemux.c:834:          case
GST_SEEK_TYPE_CUR:
./gst-plugins-base/gst-libs/gst/tag/gsttagdemux.c:854:          case
GST_SEEK_TYPE_CUR:
./gstreamer/gst/gstsegment.c:304:    case GST_SEEK_TYPE_CUR:
./gstreamer/gst/gstsegment.c:338:    case GST_SEEK_TYPE_CUR:

> find . -name "*.c" -exec grep -Hn "GST_SEEK_TYPE_END" {} \; | egrep -v "(check|enum)"
./gst-plugins-bad/gst/tta/gstttaparse.c:193:          case GST_SEEK_TYPE_END:
./gst-plugins-bad/ext/metadata/gstbasemetadata.c:1477:      else if (start_type
== GST_SEEK_TYPE_END) {
./gst-plugins-bad/ext/metadata/gstbasemetadata.c:1502:      else if (stop_type
== GST_SEEK_TYPE_END) {
./gst-plugins-base/gst-libs/gst/cdda/gstcddabasesrc.c:774:      case
GST_SEEK_TYPE_END:
./gst-plugins-base/gst-libs/gst/cdda/gstcddabasesrc.c:799:      case
GST_SEEK_TYPE_END:
./gst-plugins-base/gst-libs/gst/tag/gsttagdemux.c:836:          case
GST_SEEK_TYPE_END:
./gst-plugins-base/gst-libs/gst/tag/gsttagdemux.c:856:          case
GST_SEEK_TYPE_END:
./gstreamer/gst/gstsegment.c:309:    case GST_SEEK_TYPE_END:
./gstreamer/gst/gstsegment.c:346:    case GST_SEEK_TYPE_END:

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.