[gstreamer-bugs] [Bug 577784] Implement full H.263/+/++ caps negotiation according to RFC4629

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=577784
  GStreamer | gst-plugins-good | git

Mark Nauwelaerts <mnauw> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnauw at users.sourceforge.net

--- Comment #14 from Mark Nauwelaerts <mnauw at users.sourceforge.net> 2010-04-19 12:08:43 UTC ---
(In reply to comment #2)
> Created an attachment (id=131947)
 View: https://bugzilla.gnome.org/attachment.cgi?id=131947
 Review: https://bugzilla.gnome.org/review?bug=577784&attachment=131947

> good-002: rtph263ppay: Implement getcaps following RFC 4629, picks the right
> annexes

>+static GstCaps *
>+gst_rtp_h263p_pay_sink_getcaps (GstBaseRTPPayload * payload, GstPad * pad)
>+{
>+  GstRtpH263PPay *rtph263ppay;
>+  GstCaps *caps = gst_caps_new_empty ();
>+  GstCaps *peercaps = NULL;
>+  GstCaps *intersect = NULL;
>+  guint i;
>+
>+  rtph263ppay = GST_RTP_H263P_PAY (payload);
>+
>+  peercaps = gst_pad_peer_get_caps (GST_BASE_RTP_PAYLOAD_SRCPAD (payload));
>+  if (!peercaps)
>+    return NULL;

If I read core right, it would go g_critical when getting NULL from a getcaps
function, so this might have to be template caps instead (or whatever is tried
to express here).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.