[gstreamer-bugs] [Bug 613066] [flvmux] review is-live property before release

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Apr 22 06:01:12 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=613066
  GStreamer | gst-plugins-good | git

--- Comment #9 from Jan Urbański <wulczer at wulczer.org> 2010-04-22 13:01:09 UTC ---
So what would disabling that property mean? I think we could just remove it
from the element interface and treat is as always FALSE.

The consequences will be:

 * for non-seekable downstream a big, empty blob will be sent in the onMetadata
script tag, but the output will still be valid FLV, so that's not too bad
 * for live streaming the element will barf after G_MAXINT32 miliseconds (too
lazy to compute how much is that in days), but for the typical use case of
"create an FLV file" it's not a problem
 * for live streaming the element will keep building a keyframes index in
memory, which will constitute a small memory leak. Since live streaming wno't
work for very long anyway, that's also fine.

So I'm for just making all references to mux->is_live a constant FALSE (and
fixing it afterwards, of course).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list