[gstreamer-bugs] [Bug 616846] Crash in gst_interpolation_control_source_find_control_point_iter

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=616846
  GStreamer | gstreamer (core) | git

--- Comment #1 from Benjamin Otte (Company) <otte at gnome.org> 2010-04-26 13:53:19 UTC ---
Created an attachment (id=159598)
 View: https://bugzilla.gnome.org/attachment.cgi?id=159598
 Review: https://bugzilla.gnome.org/review?bug=616846&attachment=159598

controller: Fix gst_interpolation_control_source_find_control_point_iter

The logic in that function is broken. Various NULL-checking bandaids for
guaranteed non-NULL variables didn't even help there.

This patch updates the function to check if a previous item exists
before fetching it instead of after. This makes all other tests
unnecessary.
In particular, it makes the check for an empty list unnecessary, because
for empty lists the only iter is the begin iter (and the end iter) and
so the new check catches that case.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.