[gstreamer-bugs] [Bug 616846] Crash in gst_interpolation_control_source_find_control_point_iter

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=616846
  GStreamer | gstreamer (core) | git

Benjamin Otte (Company) <otte> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #159598|reviewed                    |committed
             status|                            |

--- Comment #4 from Benjamin Otte (Company) <otte at gnome.org> 2010-04-26 14:48:12 UTC ---
(From update of attachment 159598)
commit 6fb4cda8fb84c203d562adfe3eb9ed37218c42f8
Author: Benjamin Otte <otte at redhat.com>
Date:   Mon Apr 26 15:43:17 2010 +0200

    controller: Fix gst_interpolation_control_source_find_control_point_iter

    The logic in that function is broken. Various NULL-checking bandaids for
    guaranteed non-NULL variables didn't even help there.

    This patch updates the function to check if a previous item exists
    before fetching it instead of after. This makes all other tests
    unnecessary.
    In particular, it makes the check for an empty list unnecessary, because
    for empty lists the only iter is the begin iter (and the end iter) and
    so the new check catches that case.

    https://bugzilla.gnome.org/show_bug.cgi?id=616846

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.