[gstreamer-bugs] [Bug 617078] New: Wrong include paths in amr elements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=617078
  GStreamer | gst-plugins-ugly | git

           Summary: Wrong include paths in amr elements
    Classification: Desktop
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: trivial
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.sourceforge.net
        ReportedBy: lrn1986 at gmail.com
         QAContact: gstreamer-bugs at lists.sourceforge.net
      GNOME target: ---
     GNOME version: ---


Amr elements include openamr headers like this:
#include <opencore-amrnb/dec_if.h>
However, this is incorrect, because opencore-amrnb has this in its .pc file:
includedir=${prefix}/include/opencore-amrnb
So, the correct way to include dec_if.h is:
#include <def_if.h>
configure.ac does have PKG_CHECK_MODULES(AMRNB, ...) and ext/amrnb/Makefile.am
does have AMRNB_CFLAGS put into CFLAGS, so there's no reason to continue to
rely on opencore-amrnb directory being in include path (although configure.ac
also has a fallback in case PKG_CHECK_MODULES() fails, and that fallback
doesn't look too good, as it would only work with opencore-amrnb in include
path)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.