[gstreamer-bugs] [Bug 614305] [PLUGIN-MOVE] oss4 should be moved to good
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Apr 29 05:29:01 PDT 2010
https://bugzilla.gnome.org/show_bug.cgi?id=614305
GStreamer | gst-plugins-bad | 0.10.18
Tim-Philipp Müller <t.i.m> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
Target Milestone|HEAD |0.10.19
Severity|enhancement |blocker
--- Comment #15 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-04-29 12:28:56 UTC ---
> Created an attachment (id=159111)
View: https://bugzilla.gnome.org/attachment.cgi?id=159111
Review: https://bugzilla.gnome.org/review?bug=614305&attachment=159111
> updated patch to add GstStreamVolume
This was missing the header file change.
> 1) Now get/set volume/mute is done with helper functions.
Ok, I've moved the getters up to the setters to they're closer together. Also,
I've changed the error code paths in the getters a bit so they don't operate on
invalid/undefined values.
> 2) Added GST_OBJECT_LOCK/GST_OBJECT_UNLOCK calls surrounding ioctl calls.
Great.
> 3) Added the g_type_add_interface_static () call for
> GST_TYPE_IMPLEMENTS_INTERFACE.
I've removed all the GstImplementsInterface stuff. It's not needed here and we
want to get rid of this horrible interface, so no point adding it here for no
reason.
> I think this fixes the major issues raised about this patch. Is there any more
> work that needs to be done?
Nothing I can think of right now. I'm happy to move it as it is, although
technically we still need someone to review the code for sanity and compliance
with the moving-plugins guidelines. Not sure if Sebastian or anyone else have
already done that.
> Note that I did not change mute_volume so that it is stored as a single mono
> volume value internally. This seems a bad idea to me for several reasons. (...)
Makes sense.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Gstreamer-bugs
mailing list