[gstreamer-bugs] [Bug 574416] rtp{theora, vorbis}depay should accept in-line configuration (too)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=574416
  GStreamer | gst-plugins-good | git

--- Comment #5 from Olivier Crete (Tester) <tester at tester.ca> 2010-04-29 21:05:05 UTC ---
Review of attachment 159331:
 --> (https://bugzilla.gnome.org/review?bug=574416&attachment=159331)

::: gst/rtp/gstrtptheoradepay.c
@@ +626,3 @@
+    /* fatal, as we otherwise risk carrying on without output */
+    GST_ELEMENT_ERROR (rtptheoradepay, STREAM, DECODE,
+        (NULL), ("Packet contains invalid configuration"));

I would prefer if we just dropped packets until a valid config comes. And maybe
emit some kind of non-fatal message. This way, when we implement AVPF, we can
inform the other side to re-send it. That said, I plan to do AVPF in the not so
distant future, so I'll figure out the message and stuff.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.