[gstreamer-bugs] [Bug 625862] [docs] unused symbol GST_CAT_LEVEL_LOG_valist breaks the build

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=625862
  GStreamer | gstreamer (core) | git

--- Comment #7 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> 2010-08-03 11:15:25 UTC ---
(In reply to comment #6)
> Still wonder why this breaks for you but not for me (I also have stuff in
> -unused.txt, but not this one).
> 
> Is that DOCS_ARE_INCOMPLETE_PLEASE_FIXME variable defined in your
> environment/.spec file/whatever?

Nope, but without this patch a I got the following error:

*** Rebuilding template files ***
if test x"." != x. ; then \
            cp ./gstreamer-sections.txt . ; \
            touch gstreamer-decl.txt ; \
        fi
gtkdoc-mktmpl --module=gstreamer | tee tmpl-build.log
./gstreamer-decl.txt:9937: warning: GstTagList has multiple definitions.
./gstreamer-unused.txt:1: warning: 1 unused declarations.They should be added
to gstreamer-sections.txt in the appropriate place.
make[1]: *** [tmpl-build.stamp] Error 1
make[1]: Leaving directory `/home/vjaquez/checkout/gnome2/gstreamer/docs/gst'
make: *** [all] Error 2

And the gstreamer-unused.txt file contains the symbol GST_CAT_LEVEL_LOG_valist

With this patch, if I run `make tmpl-build.stamp` everything goes smooth and no
symbols are stored in gstreamer-unused.txt

I guess these lines in common/gtk-doc.mak throw this error

    @if test -s $(DOC_MODULE)-unused.txt; then \
        exit $(if $(DOCS_ARE_INCOMPLETE_PLEASE_FIXME),0,1); fi

As you may see, the exit command is executed, only the result value changes if
the $DOCS_ARE_INCOMPLETE_PLEASE_FIXME is set or not.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.