[gstreamer-bugs] [Bug 625959] geometrictransform: make CircleGeometricTransform "radius" property relative

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=625959
  GStreamer | gst-plugins-bad | unspecified

--- Comment #2 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2010-08-03 22:01:22 UTC ---
Review of attachment 167058:
 --> (https://bugzilla.gnome.org/review?bug=625959&attachment=167058)

Found one suspicious change, the others looks fine.

::: gst/geometrictransform/gstcirclegeometrictransform.c
@@ +159,3 @@
+      cgt->radius * sqrt (0.5 * (gt->width * gt->width +
+          gt->height * gt->height));
+  cgt->precalc_radius2 = cgt->precalc_radius * cgt->precalc_radius;

Shouldn't the 0.5 be outside the sqrt?

the sqrt calculates the diagonal length, and you split it in half to get the
maximum radius, right?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.