[gstreamer-bugs] [Bug 621404] [dvbsrc] Set stats-reporting-interval on construction

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=621404
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
         AssignedTo|gstreamer-bugs at lists.source |t.i.m at zen.co.uk
                   |forge.net                   |
     Ever Confirmed|0                           |1

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-08-06 01:00:57 UTC ---
Created an attachment (id=167227)
 View: https://bugzilla.gnome.org/attachment.cgi?id=167227
 Review: https://bugzilla.gnome.org/review?bug=621404&attachment=167227

dvbsrc: align actual default values for properties with defaults in param spec

G_PARAM_CONSTRUCT works as a solution, but in GStreamer we don't use that
really, we have DEFAULT_ defines and then assign the values in the instance
init function, so let's do that instead.

There were many other properties where the actual defaults didn't line up with
the alleged defaults. I hope this doesn't break anything.

gst-inspect-0.10 diff looks like this:


@@ -94,7 +94,7 @@
                         Unsigned Integer. Range: 0 - 4294967295 Default: 0
Current: 0
   bandwidth           : Bandwidth (DVB-T)
                         flags: readable, writable
-                        Enum "GstDvbSrcBandwidth" Default: 1, "7" Current: 0,
"8"
+                        Enum "GstDvbSrcBandwidth" Default: 1, "7" Current: 1,
"7"
                            (0): 8                - 8
                            (1): 7                - 7
                            (2): 6                - 6
@@ -114,7 +114,7 @@
                            (9):                  - AUTO
   code-rate-lp        : Low Priority Code Rate (DVB-T)
                         flags: readable, writable
-                        Enum "GstDvbSrcCode_Rate" Default: 1, "1/2" Current:
0, "NONE"
+                        Enum "GstDvbSrcCode_Rate" Default: 1, "1/2" Current:
1, "1/2"
                            (0): NONE             - NONE
                            (1): 1/2              - 1/2
                            (2): 2/3              - 2/3
@@ -127,7 +127,7 @@
                            (9):                  - AUTO
   guard               : Guard Interval (DVB-T)
                         flags: readable, writable
-                        Enum "GstDvbSrcGuard" Default: 1, "16" Current: 0,
"32"
+                        Enum "GstDvbSrcGuard" Default: 1, "16" Current: 1,
"16"
                            (0): 32               - 32
                            (1): 16               - 16
                            (2): 8                - 8
@@ -135,7 +135,7 @@
                            (4): AUTO             - AUTO
   modulation          : Modulation (DVB-T and DVB-C)
                         flags: readable, writable
-                        Enum "GstDvbSrcModulation" Default: 1, "QAM 16"
Current: 0, "QPSK"
+                        Enum "GstDvbSrcModulation" Default: 1, "QAM 16"
Current: 1, "QAM 16"
                            (0): QPSK             - QPSK
                            (1): QAM 16           - QAM 16
                            (2): QAM 32           - QAM 32
@@ -147,13 +147,13 @@
                            (8): 16VSB            - 16VSB
   trans-mode          : Transmission Mode (DVB-T)
                         flags: readable, writable
-                        Enum "GstDvbSrcTransmission_Mode" Default: 1, "8k"
Current: 0, "2k"
+                        Enum "GstDvbSrcTransmission_Mode" Default: 1, "8k"
Current: 1, "8k"
                            (0): 2k               - 2k
                            (1): 8k               - 8k
                            (2): AUTO             - AUTO
   hierarchy           : Hierarchy Information (DVB-T)
                         flags: readable, writable
-                        Enum "GstDvbSrcHierarchy" Default: 1, "1" Current: 0,
"NONE"
+                        Enum "GstDvbSrcHierarchy" Default: 1, "1" Current: 1,
"1"
                            (0): NONE             - NONE
                            (1): 1                - 1
                            (2): 2                - 2
@@ -164,10 +164,10 @@
                         Pointer. Write only
   inversion           : Inversion Information (DVB-T and DVB-C)
                         flags: readable, writable
-                        Enum "GstDvbSrcInversion" Default: 1, "ON" Current: 0,
"OFF"
+                        Enum "GstDvbSrcInversion" Default: 1, "ON" Current: 1,
"ON"
                            (0): OFF              - OFF
                            (1): ON               - ON
                            (2): AUTO             - AUTO
   stats-reporting-interval: The number of reads before reporting frontend
stats
                         flags: readable, writable
-                        Unsigned Integer. Range: 0 - 4294967295 Default: 100
Current: 0
+                        Unsigned Integer. Range: 0 - 4294967295 Default: 100
Current: 100

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.