[gstreamer-bugs] [Bug 623063] jpegdec error-after property

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Aug 8 03:53:06 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=623063
  GStreamer | gst-plugins-good | 0.10.22

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164834|none                        |needs-work
             status|                            |

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-08-08 10:53:00 UTC ---
(From update of attachment 164834)
I think the property should be called "max-errors" or somesuch, not
"error-after" ("error-after" means something else).

Also, I wonder if one can do something to make these if/else constructions that
repeat the error message/debug stuff prettier. (A macro maybe?)

Furthermore, your patch contains tabs. If you can't be bothered to install gnu
indent and gst-indent to make sure your code and patches adhere to the coding
guidelines, please at least attempt to mimic the indentation style (for *.c
files only, not header files), which is: indentation with spaces, no tabs. This
also makes the patch easier to read and review. Thanks!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list