[gstreamer-bugs] [Bug 396774] Make GstElementDetails extensible

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=396774
  GStreamer | gstreamer (core) | git

--- Comment #19 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-10 12:20:30 UTC ---
Review of attachment 167500:
 --> (https://bugzilla.gnome.org/review?bug=396774&attachment=167500)

Looks good, two minor things below

::: gst/gstelement.c
@@ +1240,3 @@
+
+  if (klass->meta_data) {
+    GST_DEBUG ("clear metadata in class %p to %p", klass, klass->meta_data);

So this means, that the metadata of the parent class is overwritten.

I think for 0.11 we might want to change that, same for the other element
details. For example for inheriting the classification of the parent class

@@ +1250,3 @@
+}
+
+/* FIXME-0.11: deperate and remove gst_element_class_set_details*() */

small typo, deprecate ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.