[gstreamer-bugs] [Bug 396774] Make GstElementDetails extensible
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Aug 10 05:38:28 PDT 2010
https://bugzilla.gnome.org/show_bug.cgi?id=396774
GStreamer | gstreamer (core) | git
--- Comment #21 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-10 12:38:23 UTC ---
(In reply to comment #19)
> Review of attachment 167500 [details]:
>
> Looks good, two minor things below
>
> ::: gst/gstelement.c
> @@ +1240,3 @@
> +
> + if (klass->meta_data) {
> + GST_DEBUG ("clear metadata in class %p to %p", klass, klass->meta_data);
>
> So this means, that the metadata of the parent class is overwritten.
>
> I think for 0.11 we might want to change that, same for the other element
> details. For example for inheriting the classification of the parent class
Oh and you might want to enforce the clearing of the metadata in
GstElement::base_init to get really the same behaviour as for the other element
details.
And if we agree that something like your patch should go in, we should first
define metadata fields and their usage. Otherwise elements might use different
fields for the same thing...
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Gstreamer-bugs
mailing list