[gstreamer-bugs] [Bug 626618] jpegparse doesn't handle APP12 marker

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626618
  GStreamer | gst-plugins-bad | git

--- Comment #10 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-08-12 20:14:38 UTC ---
(From update of attachment 167768)
>+        } else if (marker >= APP0 && marker <= APP15) {
>+          const gchar *id_str;
>+          if (!gst_byte_reader_get_uint16_be (&reader, &size))
>+            goto error;
>+          if (!gst_byte_reader_get_string_utf8 (&reader, &id_str))
>+            goto error;
>+          if (!gst_byte_reader_skip (&reader, size - 3 - strlen (id_str)))
>+            goto error;
>+          GST_LOG_OBJECT (parse, "application marker %x: '%s' skiping %u bytes",
>+              marker, id_str, size - 2);

I'm not so sure about / keen on the ID string check. What's its purpose? Why
not just skip the segment based on the size given and be done with it? I bet
there are APP segments without a 0-terminated ID string..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.