[gstreamer-bugs] [Bug 626618] jpegparse doesn't handle APP12 marker

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=626618
  GStreamer | gst-plugins-bad | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #167789|none                        |reviewed
             status|                            |

--- Comment #19 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-08-13 11:55:45 UTC ---
(From update of attachment 167789)
>       case COM:{               /* read comment and post as tag */
>         GstTagList *tags;
>-        const guint8 *comment = NULL;
>+        const guint8 *comment;

I think the initialization here might be needed to avoid compiler warnings
somewhere (osx build bot?).

>         if (!gst_byte_reader_get_uint16_be (&reader, &size))
>           goto error;
>         if (!gst_byte_reader_get_data (&reader, size - 2, &comment))
>           goto error;
>         ...
>+       if (g_utf8_validate ((char *) comment, -1, NULL)) {
>             ...
>+       }
>         break;
>       }

Is this safe? I think g_utf8_validate() may end up reading beyond the allocated
memory if there's no 0 in the data, because of the -1 length.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.