[gstreamer-bugs] [Bug 623063] [jpegdec] add "max-errors" property

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=623063
  GStreamer | gst-plugins-good | 0.10.22

--- Comment #8 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2010-08-14 13:38:36 UTC ---
> -1 means to always do the default behavior. In the future it could be expanded
> to mean different things for different modes.
> My goal here was to reduce impact to the maximum extent possible.

Ok, not a problem, should just be documented in the property description, e.g.:
"Error out after this many consecutive decoding errors (-1 = automatic)" (feel
free to rephrase this)

> +    case PROP_MAX_ERRORS:
> +      dec->max_errors = g_value_get_int (value);
> 
> What do you suggest be done? Leave it as is since it's mirroring other
> properties?

I'm fine with a /* FIXME: not thread-safe */, but fixing the code to use
g_atomic_int_{set|get} for this structure member is also not particularly hard
if you want to take a stab.

>      case GST_STATE_CHANGE_READY_TO_PAUSED:
> +      dec->max_error_count = dec->max_errors;
> 
> Elsewhere we're setting the error count to zero when good frames come in. This
> just ensures that the error count is capped at every ready -> paused transition
> (in case you had more than max_errors before the pipeline was able to
> shutdown).

I'm not sure I understand this. The question for me is basically: does this
work if the very first frame is broken, but all consecutive frames are fine? (I
think not?)



(In reply to comment #7)
> I was curious on what the feasibility would be of using GST_ELEMENT_WARNING
> instead of GST_ELEMENT_INFO?  I'm not trying to split hairs here, but to me a
> random bad decode could be indicative of something possibly being bad (hence
> the warning).

Yes, making this GST_ELEMENT_WARNING is probably more  appropriate.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.