[gstreamer-bugs] [Bug 624338] [pulsesink] double-free exception

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=624338
  GStreamer | gst-plugins-good | git

--- Comment #18 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-16 10:23:42 UTC ---
(In reply to comment #16)

> > Then it might make sense to add a property to set the pulse client name. E.g.
> > in webkit you might want to have all pulsesinks of the same tab in the same
> > pulse client but not all pulsesinks of all tabs.
> > 
> 
> Good idea indeed, could that go in a separate bug/patch? I'd be fine with doing
> it here but the current patch is already big I think.

No, do it as a separate patch. The patch, after fixing the thread safety issue,
is already big enough as you said. I always prefer many small patches over one
large.

> > Also, gst_pulse_client_name() should maybe be improved and return something
> > like "GStreamer ($PID)" when the other two ways to get a name fail.
> 
> Ok, will do that in next iteration of the patch.

But do it as a separate patch too please. It's related to this change but not
really the same

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.