[gstreamer-bugs] [Bug 626181] [pbutils] Add enhanced gstfactorylists

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Aug 16 03:29:05 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=626181
  GStreamer | gst-plugins-base | git

--- Comment #13 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-16 10:29:00 UTC ---
(In reply to comment #11)

> > For this you might want to take a look at
> > http://svn.debian.org/viewsvn/pkg-gstreamer/unstable/gstreamer0.10/debian/gst-codec-info.c?revision=3298&view=markup
> > 
> > Search for "codec_data" and remove_min_max_fields(). I think that's a bit safer
> > and better than simply removing *all* ranges.
> 
>   Agreed, but I wouldn't blindly remove the width/height/formats fields for
> example. They will be needed, for example, if you have several different
> encoders available which can only handle certain formats/sizes.

Right, for width/height/depth you probably want to check if it's a range over
all possible values

> > @@ +61,3 @@
> > +  GST_FACTORY_LIST_DEPAYLOADER  = (1 << 8),
> > +
> > +  GST_FACTORY_LIST_MAX_ELEMENTS = (1 << 16),
> > 
> > If you want to add special purpose elements here 16 might be too small
> 
>   I'll make it << 24, that should be enough.

I was more thinking of a 64 bit enum

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the Gstreamer-bugs mailing list