[gstreamer-bugs] [Bug 627204] Some audio-based depayloaders are sometimes incorrectly indicating discont flag and RTP-marker bit.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627204
  GStreamer | gst-plugins-good | 0.10.24

--- Comment #7 from Olivier Crete (Tester) <tester at tester.ca> 2010-08-17 19:56:41 UTC ---
Review of attachment 168125:
 --> (https://bugzilla.gnome.org/review?bug=627204&attachment=168125)

::: gstrtppcmadepay.c
@@ +145,3 @@
+    gboolean marker, guint32 timestamp)
+{
+  return (marker && timestamp != depayload->predicted_rtp_ts) ? TRUE : FALSE;

"? TRUE : FALSE" is entirely redundant here

@@ +175,3 @@

+  if (!GST_BUFFER_IS_DISCONT (buf) &&
+      gst_rtp_pcma_depay_is_talkspurt (depay, marker, timestamp)) {

Do you really mean to never set the discont flag on the output if it was set on
the input buffer ? Shouldn't it be "GST_BUFFER_IS_DISCONT (buf) && .." ? Or am
I lost ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.