[gstreamer-bugs] [Bug 626784] element: link_many might assert elements are in paused or playing

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Aug 19 03:52:15 PDT 2010


https://bugzilla.gnome.org/show_bug.cgi?id=626784
  GStreamer | gstreamer (core) | git

--- Comment #6 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2010-08-19 10:52:10 UTC ---
The state lock is used in 3 functions in gstelement:

1) send_event
2) set_state
3) finalize

Don't see exactly how adding a pad can conflict with those. But I might be
wrong too :)

Looking on the other way, the add_pad from gstelement doesn't hold the lock
while testing if the pad is flushing, comparing with the element state and then
activating it if needed (with a proper warning).

I guess we're assuming that the user is not supposed to be adding pads and
changing states at the same time. So we might leave this patch without the lock
at all.

In any case, let's have Wim's opinion.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.




More information about the Gstreamer-bugs mailing list