[gstreamer-bugs] [Bug 627211] jpegformat: Push tags after setting srcpad caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627211
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168137|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-19 16:15:21 UTC ---
Review of attachment 168137:
 --> (https://bugzilla.gnome.org/review?bug=627211&attachment=168137)

::: gst/jpegformat/gstjpegparse.c
@@ +944,3 @@
       gst_adapter_clear (parse->priv->adapter);
+      if (parse->priv->tags)
+        gst_tag_list_free (parse->priv->tags);

Better set the tags to NULL here. It's almost impossible that something goes
wrong that bad that the taglist would be accessed again after this point and
without going through one of the other places to set it to NULL but it can't
hurt ;)

Apart from that you should also cache the tags that come from upstream.

Other than that the patch is good :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.