[gstreamer-bugs] [Bug 627211] jpegformat: Push tags after setting srcpad caps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627211
  GStreamer | gst-plugins-bad | unspecified

--- Comment #4 from Arun Raghavan <arun at accosted.net> 2010-08-23 16:22:02 UTC ---
(In reply to comment #2)
> Review of attachment 168137 [details]:
> 
> ::: gst/jpegformat/gstjpegparse.c
> @@ +944,3 @@
>        gst_adapter_clear (parse->priv->adapter);
> +      if (parse->priv->tags)
> +        gst_tag_list_free (parse->priv->tags);
> 
> Better set the tags to NULL here. It's almost impossible that something goes
> wrong that bad that the taglist would be accessed again after this point and
> without going through one of the other places to set it to NULL but it can't
> hurt ;)

I just had this feeling that I shouldn't be tempting fate there, but I ignored
it. Fixed now.

> Apart from that you should also cache the tags that come from upstream.

Also fixed.

> Other than that the patch is good :)

Thanks for the review!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.