[gstreamer-bugs] [Bug 627780] GstClockOverlay re-renders string even if it hasn't changed, resulting in very high CPU usage.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627780
  GStreamer | gst-plugins-base | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |slomo at circular-chaos.org
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.31

--- Comment #1 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-24 07:30:26 UTC ---
commit 6bd90dc0cc742390c2f1e842e1f026a3503ded63
Author: Chris Shoemaker <chris.shoemaker at cox.net>
Date:   Mon Aug 23 18:51:18 2010 -0400

    clockoverlay: only rerender text if time string has changed

    The textoverlay element will rerender the text string whenever
    overlay sets the 'need_render' flag to TRUE.  Previously, we
    lazily set the flag to TRUE every time the time string was requested.
    Now, we save a copy of the previously given string, and only set
    'need_render' to TRUE if the string has changed.

    In my tests with a 30fps video stream, and a time string including
    a seconds field, this change reduced the CPU usage of the clockoverlay
    element from 60% to 5%.

    Fixes bug #627780.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.