[gstreamer-bugs] [Bug 627796] rtpbin: add ntp clock sync

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627796
  GStreamer | gst-plugins-good | unspecified

--- Comment #3 from Olivier Crete (Tester) <tester at tester.ca> 2010-08-24 16:38:52 UTC ---
Review of attachment 168612:
 --> (https://bugzilla.gnome.org/review?bug=627796&attachment=168612)

::: gst/rtpmanager/gstrtpsession.c
@@ +767,3 @@

+    if (rtpsession->ntp_sync) {
+      ntpns = gst_clock_get_time (clock);

If I understand, all you are doing is using the pipeline clock for the NTP time
instead of a system clock ? So shouldn't the property be called
"use-pipeline-clock".. And why is it not the default ? Is it because the
pipeline clock can be changed?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.