[gstreamer-bugs] [Bug 627826] GstInt64Range type

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=627826
  GStreamer | gstreamer (core) | git

Sebastian Dröge <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168735|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge <slomo at circular-chaos.org> 2010-08-25 17:26:14 UTC ---
Review of attachment 168735:
 --> (https://bugzilla.gnome.org/review?bug=627826&attachment=168735)

Looks good in general, some minor comments below :)

Also, while we're at it, it might make sense to add real C types for the
ranges, fractions, lists, arrays and fourccs. But that's for another patch.
Maybe you want to use that for the buffering ranges though

::: gst/gststructure.c
@@ +1857,3 @@
+    g_value_init (value, range_type);
+    gst_value_set_int64_range (value, gst_g_value_get_int_unchecked (&value1),
+        gst_g_value_get_int_unchecked (&value2));

Use gst_g_value_get_int64_unchecked() here, otherwise you'll drop 32 bits of
the value

::: tests/check/gst/gstvalue.c
@@ +2427,3 @@
+    g_strdup_printf ("[ 0, %" G_GINT64_FORMAT " ]", (gint64) G_MAXINT),
+    g_strdup_printf ("[ 5, %" G_GINT64_FORMAT " ]", (gint64) G_MAXINT32),
+    g_strdup_printf ("[ 5, %" G_GINT64_FORMAT " ]", G_MAXINT64),

You're leaking these strings

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.